-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AUTH var substitutions to pingback/login URLs. #1456
Conversation
@@ -515,7 +537,7 @@ export class AccessService { | |||
log.fine(TAG, 'Ignore pingback'); | |||
return Promise.resolve(); | |||
} | |||
return this.buildUrl_(this.config_.pingback).then(url => { | |||
return this.buildUrl_(this.config_.pingback, true).then(url => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment for boolean flag name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@cramforce PTAL |
// Value 0 is specialcased because the numeric 0 is a valid substitution | ||
// value. | ||
if (!val && val !== 0) { | ||
if (val === null || val === undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val == null
does both
LGTM |
Add AUTH var substitutions to pingback/login URLs.
No description provided.