isDevChannel method and whitelist for access #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvoytenko LGTM, final word from @cramforce |
| @@ -33,6 +33,9 @@ var privateServiceFactory = 'This service should only be installed in ' + | |||
| 'the whitelisted files. Other modules should use a public function ' + | |||
| 'typically called serviceNameFor.'; | |||
|
|
|||
| var shouldNeverBeUsed = | |||
| 'Usage of this API requires is not allowed - only for internal purposes.'; | |||
There was a problem hiding this comment.
"Usage of this API is not allowed - ..."
dvoytenko
force-pushed
the
devchannel1
branch
from
fdf6376
to
4c02e24
Compare
|
LGTM |
dvoytenko
added a commit
that referenced
this pull request
Jan 15, 2016
isDevChannel method and whitelist for access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @erwinmombay