Broadcast event in viewer #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ericfs please see the implementation in the |
|
@dvoytenko you think we should render a different doc for contrast? |
| function showContainer(id) { | ||
| log('Show container: ', id); | ||
| var viewerEl = document.querySelector('viewer'); | ||
| viewerEl.setAttribute('data-show-container', id); |
There was a problem hiding this comment.
why did we have to go through the attribute route instead of a class?
There was a problem hiding this comment.
Only for convenience. Easier to set a single value than toggle different classes on/off.
|
LGTM |
|
@erwinmombay would like a different document, but I only have :) Eventually we will just allow URLs to be passed as arguments to this sample. |
|
@dvoytenko LGTM |
dvoytenko
pushed a commit
to dvoytenko/amphtml
that referenced
this pull request
Jan 14, 2016
Broadcast event in viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.