Instruct Resources manager to remeasure/layout/unload for mutated subtrees. #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| setRelayoutTop_(relayoutTop) { | ||
| if (this.relayoutTop_ == -1) { | ||
| this.relayoutTop_ = relayoutTop; |
There was a problem hiding this comment.
The "pass" remeasures all elements under this one. This is what we use for height changes to update siblings.
|
Looks fine |
dvoytenko
force-pushed
the
access17
branch
2 times, most recently
from
9a8a5a7
to
f2fb23f
Compare
dvoytenko
changed the title
|
@cramforce implementation and tests have been completed. PTAL. |
…ts and their siblings.
|
LGTM |
dvoytenko
added a commit
that referenced
this pull request
Jan 14, 2016
Instruct Resources manager to remeasure/layout/unload for mutated subtrees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cramforce PTAL. Tests in progress.