Switch production codegen to use closure compiler. #1390
Conversation
cramforce
force-pushed
the
cc-all-the-things
branch
from
1b7b230
to
a9e110d
Compare
|
woot, nice find on the compiler issue (for the spread) |
cramforce
force-pushed
the
cc-all-the-things
branch
4 times, most recently
from
6d62efc
to
d5c4569
Compare
|
@erwinmombay Do you want to do a review?
|
| .pipe(rename(outputFilename + '.map')) | ||
| .pipe(gulp.dest(outputDir)) | ||
| .on('end', resolve); | ||
| return gulp.src(intermediateFilename) |
There was a problem hiding this comment.
does this work correctly? i don't think iv'e ever started a read (using gulp.src) again on an event. ideally we'd break these down into smaller gulp tasks so we can sequence them correctly.
/cc @jridgewell
There was a problem hiding this comment.
It does work. Although I hate gulp and don't want to learn it :)
There was a problem hiding this comment.
i'm perfectly fine with this as long as it works. was just worried if there was anything racy (because of async nature of tasks. guessing gulp knows its still working)
haha yes, gulp likes to make things that are supposed to be easy slightly hard sometimes..
There was a problem hiding this comment.
Why are we using an intermediate file name at all?
There was a problem hiding this comment.
Just for the gulp-replace, I can get rid of it for the source map.
There was a problem hiding this comment.
Can you do the replace before passing it to closure?
There was a problem hiding this comment.
I can't because the gulp-closure plugin doesn't actually work on streams.
|
@cramforce besides the questions, LGTM |
cramforce
force-pushed
the
cc-all-the-things
branch
2 times, most recently
from
a048ebe
to
d3768c4
Compare
|
Now with 100% less hacks :) |
cramforce
changed the title
cramforce
force-pushed
the
cc-all-the-things
branch
from
d3768c4
to
6e761bb
Compare
cramforce
force-pushed
the
cc-all-the-things
branch
from
6e761bb
to
25f678a
Compare
|
YOLO |
Switch production codegen to use closure compiler.
Production part of #86. Does not implement type checking.