Change error integration test to use fragment based dev-mode inference #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es instead of the legacy attribute based code path. Also fixes the validator integration test to use the new validator URL and provides for a way to turn on dev mode while a page is embedded into a viewer (through the viewer). Part of ampproject#999
|
CC @jmadler |
|
@dvoytenko do you have any concerns? |
| @@ -59,11 +59,13 @@ function getMode_() { | |||
| // occur during local dev. | |||
| !!document.querySelector('script[src*="/dist/"],script[src*="/base/"]'); | |||
|
|
|||
| const overrideDevelopment = parseQueryString(location.hash)['development']; | |||
| const overrideDevelopment = parseQueryString( | |||
| // location.originalHash is set by the viewer when it removes the fragment | |||
There was a problem hiding this comment.
FYI, Viewer also remembers all original args in hash and can return them via getParam(name). You can always use this if convenient/possible.
There was a problem hiding this comment.
Don't want mode.js depend on viewer.
|
Couple comments, but otherwise LGTM. |
cramforce
added a commit
that referenced
this pull request
Jan 13, 2016
Change error integration test to use fragment based dev-mode inference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the legacy attribute based code path.
Also fixes the validator integration test to use the new validator URL and provides for a way to turn on dev mode while a page is embedded into a viewer (through the viewer).
Part of #999