feature(changelog): Make changelog create from --type flag (canary or release) #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
changed the title
| function getGitLog(tag) { | ||
| var options = { | ||
| args: 'log release...' + tag + ' --pretty=format:%s --merges' | ||
| args: 'log ' + branch + '...' + tag + ' --pretty=format:%s --merges' |
There was a problem hiding this comment.
Template strings would help here and below.
There was a problem hiding this comment.
for sure, you happen to know is it supported on node 4.0? haven't migrated our build-system files to es6 yet. (we dont even use arrow functions there yet)
There was a problem hiding this comment.
@jridgewell thanks. will make the updates as i update this file (will be making some more this week)
erwinmombay
added a commit
that referenced
this pull request
Jan 11, 2016
feature(changelog): Make changelog create from --type flag (canary or release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.