Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy support for top level html (by @powdercloud) #1344

Merged
merged 1 commit into from
Jan 7, 2016
Merged

remove legacy support for top level html (by @powdercloud) #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions validator/testdata/feature_tests/dog_doc_type.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
FAIL
feature_tests/dog_doc_type.html:23:0 DISALLOWED_ATTR 🐶
feature_tests/dog_doc_type.html:24:0 MANDATORY_ATTR_MISSING ⚡ (see https://github.com/ampproject/amphtml/blob/master/spec/amp-html-format.md#ampd)
feature_tests/dog_doc_type.html:35:7 MANDATORY_TAG_MISSING html ⚡ for top-level html (see https://github.com/ampproject/amphtml/blob/master/spec/amp-html-format.md#ampd)
9 changes: 1 addition & 8 deletions validator/validator.protoascii
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ min_validator_revision_required: 70
# newer versions of the spec file. This is currently a Google internal
# mechanism, validator.js does not use this facility. However, any
# change to this file requires updating this revision id.
spec_file_revision: 105
spec_file_revision: 106
# Rules for AMP HTML
# (https://github.com/google/amphtml/blob/master/spec/amp-html-format.md).
# These rules are just enough to validate the example from the spec.
Expand Down Expand Up @@ -68,13 +68,6 @@ tags: {
alternative_names: "amp"
}
}
# Legacy support for when the amp identification is done by doctype.
tags: {
name: "html"
detail: "top-level html"
mandatory_parent: "!doctype"
unique: true
}
# 4.2 Document metadata
# 4.2.1 The head element
tags: {
Expand Down