Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --extensions=minimal_set & bug fix #13249

Merged
merged 6 commits into from
Feb 5, 2018
Merged

Support --extensions=minimal_set & bug fix #13249

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a40ac4d
fix dist with alias
zhouyx Feb 2, 2018
ef56245
change minimal_set usage
zhouyx Feb 2, 2018
0a17de4
fix documentation
zhouyx Feb 5, 2018
80659cc
refactor print logic
zhouyx Feb 5, 2018
7ec11de
rename
zhouyx Feb 5, 2018
a15e669
update function description
zhouyx Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ function printConfigHelp(command) {
* Prints a helpful message that lets the developer know how to build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update function description too :)

* a list of extensions or without any extensions.
*/
function printExtensionsHelp() {
function parseExtensionFlags() {
if (!process.env.TRAVIS) {
if (argv.extensions) {
if (typeof(argv.extensions) !== 'string') {
Expand Down Expand Up @@ -675,7 +675,7 @@ function enableLocalTesting(targetFile) {
function performBuild(watch) {
process.env.NODE_ENV = 'development';
printConfigHelp(watch ? 'gulp watch' : 'gulp build');
printExtensionsHelp();
parseExtensionFlags();
return compileCss(watch).then(() => {
return Promise.all([
polyfillsForTests(),
Expand Down Expand Up @@ -718,7 +718,7 @@ function dist() {
if (argv.fortesting) {
printConfigHelp('gulp dist --fortesting')
}
printExtensionsHelp();
parseExtensionFlags();
return compileCss().then(() => {
return Promise.all([
compile(false, true, true),
Expand Down