XHR cleanup #1306
Merged
XHR cleanup #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jridgewell LGTM |
| @@ -0,0 +1,45 @@ | |||
| /** | |||
There was a problem hiding this comment.
Can we name this file something more specific? "util.js" is too broad. I'd be ok if we just named it "object.js".
There was a problem hiding this comment.
Are you ok with types.js?
There was a problem hiding this comment.
Yes, I think types.js is good. In general my rule of thumb is this: if you want to name something "util" or "common", first try the name "dump" - if it still works then go ahead :)
jridgewell
force-pushed
the
xhr-cleanup
branch
from
b8f109f
to
575aa0f
Compare
jridgewell
force-pushed
the
xhr-cleanup
branch
from
575aa0f
to
9e31f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normailzeMethod_functionisArrayandisObjectutilities.