Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tap configuration to avoid duplicate calls #1303

Merged
merged 1 commit into from
Jan 5, 2016

Conversation

dvoytenko
Copy link
Contributor

No description provided.

@@ -85,6 +85,9 @@ export class ActionService {
constructor(win) {
/** @const {!Window} */
this.win = win;

// Add core events.
this.addEvent('tap');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make an installEvents method, so the caller doesn't need to know about what is being installed?

@cramforce
Copy link
Member

LGTM

dvoytenko added a commit that referenced this pull request Jan 5, 2016
Move tap configuration to avoid duplicate calls
@dvoytenko dvoytenko merged commit f4ba611 into ampproject:master Jan 5, 2016
@dvoytenko dvoytenko deleted the action-fix branch January 5, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants