Pingback implementation #1294
Merged
Pingback implementation #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /** | ||
| * @return {!Promise} |
There was a problem hiding this comment.
Nice, maybe add doc:
The promise will be resolved when a view of this document has occurred. It will be rejected if the current render should not be counted as a view.
|
@cramforce All done. PTAL. |
| /** @private {!Promise<string>|undefined} */ | ||
| this.readerIdPromise_ = undefined; | ||
|
|
||
| /** @private {!Promise|undefined} */ | ||
| this.reportViewPromise_ = undefined; |
There was a problem hiding this comment.
Is there for a reason for preferring undefined over null? The type hint could be shorter with {?Promise}...
There was a problem hiding this comment.
Yeah, in this case undefined/null doesn't matter. I switched to null
|
LGTM with one stylistic comment from Justin remaining. |
| // condition and when the document becomes invisible again. | ||
| let resolve, reject; | ||
| const promise = new Promise((aResolve, aReject) => { | ||
| resolve = aResolve; |
There was a problem hiding this comment.
All the registering below could be wrapped into this resolver to avoid the deferred pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.