no padding no back gradient #12845
Merged
no padding no back gradient #12845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
requested changes
Jan 16, 2018
| @@ -73,6 +73,10 @@ | |||
| display: none !important; | |||
| } | |||
|
|
|||
| .show-first-page-overlay .i-amphtml-story-navigation-help-overlay { | |||
There was a problem hiding this comment.
Is it an issue if you simply unset padding from the general .i-amphtml-story-navigation-help-overlay selector, as opposed to overriding?
There was a problem hiding this comment.
its basically that one case need it one doesn't so as more cases come up, may be then it's a good time to refactor this
alanorozco
approved these changes
Jan 17, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
This was referenced Oct 8, 2021
This was referenced Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix to show full scale gradient in case of no previous page.