Cleanup services module #1273
Merged
Cleanup services module #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don’t call `getServices` with a second parameter (it’s not expecting it) - Reorder conditionals to make code clearer
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 561d569 (Please note that this is a fully automated comment.) |
| if (s.obj) { | ||
| return s.promise = Promise.resolve(s.obj); | ||
| if (!s.promise) { | ||
| s.promise = Promise.resolve(s.obj); |
There was a problem hiding this comment.
Web S=should probably have an assert here that s.obj is actually an object.
|
LGTM |
|
(aside: Please add "NEEDS REVIEW" label when sending PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getServiceswith a second parameter (it’s not expecting it)