Turn vsync into a core service. #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,4 +29,5 @@ export function installCoreServices(window) { | |||
| installViewerService(window); | |||
| installViewportService(window); | |||
| installHistoryService(window); | |||
| installVsyncService(window); | |||
There was a problem hiding this comment.
Seems like vsync should be one of the first to be installed, or maybe right after viewer.
There was a problem hiding this comment.
I have these install each other when needed, so that order here doesn't matter.
|
Thanks! A couple of questions, but otherwise LGTM. |
|
The increase in the core binary is because of one extra module. This could
|
Avoids loading it redundantly into extensions. Part of ampproject#1055
cramforce
force-pushed
the
vsync-service
branch
from
840dc4e
to
a41f2d9
Compare
cramforce
added a commit
that referenced
this pull request
Dec 23, 2015
Turn vsync into a core service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids loading it redundantly into extensions.
Part of #1055