-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn vsync into a core service. #1238
Conversation
@@ -28,4 +29,5 @@ export function installCoreServices(window) { | |||
installViewerService(window); | |||
installViewportService(window); | |||
installHistoryService(window); | |||
installVsyncService(window); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like vsync should be one of the first to be installed, or maybe right after viewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have these install each other when needed, so that order here doesn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. LGTM.
Thanks! A couple of questions, but otherwise LGTM. |
The increase in the core binary is because of one extra module. This could
|
Avoids loading it redundantly into extensions. Part of ampproject#1055
840dc4e
to
a41f2d9
Compare
Turn vsync into a core service.
Avoids loading it redundantly into extensions.
Part of #1055