Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change amp-analytics triggers from arrays to objects. #1193

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

btownsend
Copy link
Contributor

This changes how amp-analytics triggers are configured. Instead of specifying triggers as an array of objects, triggers are now specified as an object of objects.

This change was made because the way we merge configuration objects (built-in + vendor + inline + remote) is not effective for arrays.

The key for each trigger is an id string, used only when merging triggers from multiple configs (e.g. to override a inline trigger with a remote trigger.)

@cramforce
Copy link
Member

LGTM

cramforce added a commit that referenced this pull request Dec 18, 2015
Change amp-analytics triggers from arrays to objects.
@cramforce cramforce merged commit 4dfa7cf into ampproject:master Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants