Defer building system layer until pages have been initialized #11878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes progress bar through PAGE_PROGRESS events
…age updates progress bar through PAGE_PROGRESS events" This reverts commit 0500899.
alanorozco
approved these changes
Nov 1, 2017
neko-fire
pushed a commit
to 3qnexx/amphtml
that referenced
this pull request
Nov 17, 2017
…ject#11878) * Change progress bar to not handle active page, since active page updates progress bar through PAGE_PROGRESS events * Revert "Change progress bar to not handle active page, since active page updates progress bar through PAGE_PROGRESS events" This reverts commit 0500899. * Defer building system layer until pages have been initialized.
This was referenced Apr 16, 2021
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-storycan have children other thanamp-story-page, so naively counting children cannot work. We could countamp-story-pagetags, but this logic will also change over time as we explore experiences that may e.g. inject children, so this changes the logic to defer building the system layer until layout (at which point the pages have been initialized).