Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote config loading support to amp-analytics. #1174

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

btownsend
Copy link
Contributor

Adds support for loading remote config from a URL specified in an amp-analytics tag's config attribute.

@@ -75,6 +75,8 @@
</script>
</amp-analytics>

<amp-analytics id="analytics3" config="analytics.config.json"></amp-analytics>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the URL ./analytics.config.json to make it more obvious what is happening here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cramforce
Copy link
Member

LGTM

@btownsend
Copy link
Contributor Author

Feedback addressed and commits squashed.

@btownsend
Copy link
Contributor Author

Update to resolve conflicts with base branch.

cramforce added a commit that referenced this pull request Dec 18, 2015
Add remote config loading support to amp-analytics.
@cramforce cramforce merged commit 91ed1e2 into ampproject:master Dec 18, 2015
@cramforce
Copy link
Member

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants