Add remote config loading support to amp-analytics. #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,6 +75,8 @@ | |||
| </script> | |||
| </amp-analytics> | |||
|
|
|||
| <amp-analytics id="analytics3" config="analytics.config.json"></amp-analytics> | |||
There was a problem hiding this comment.
Make the URL ./analytics.config.json to make it more obvious what is happening here.
|
LGTM |
btownsend
force-pushed
the
analytics-remote-config
branch
from
db991e8
to
65656c9
Compare
|
Feedback addressed and commits squashed. |
btownsend
force-pushed
the
analytics-remote-config
branch
6 times, most recently
from
f6a2653
to
3d9d6b0
Compare
btownsend
force-pushed
the
analytics-remote-config
branch
from
3d9d6b0
to
91a9b05
Compare
|
Update to resolve conflicts with base branch. |
cramforce
added a commit
that referenced
this pull request
Dec 18, 2015
Add remote config loading support to amp-analytics.
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for loading remote config from a URL specified in an
amp-analyticstag'sconfigattribute.