Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP Validator feature to support disallowed ancestor tags. #1171

Merged
merged 1 commit into from
Dec 17, 2015
Merged

AMP Validator feature to support disallowed ancestor tags. #1171

merged 1 commit into from
Dec 17, 2015

Conversation

Gregable
Copy link
Member

First usage is to disallow nested template tags.

@Gregable
Copy link
Member Author

@dvoytenko

@dvoytenko
Copy link
Contributor

LGTM. Assuming the red travis is a flake. Perhaps repush to validate?

@Gregable
Copy link
Member Author

How does one repush. I tried git push --set-upstream origin <branchname>, but travis still seems oblivious.

@dvoytenko
Copy link
Contributor

Try git push -f?

On Wed, Dec 16, 2015 at 4:45 PM, Greg Grothaus notifications@github.com
wrote:

How does one repush. I tried git push --set-upstream origin ,
but travis still seems oblivious.


Reply to this email directly or view it on GitHub
#1171 (comment).

@Gregable
Copy link
Member Author

That didn't work, but logging into the travis site gave me a button to press.

@Gregable
Copy link
Member Author

Travis is green, merging.

Gregable added a commit that referenced this pull request Dec 17, 2015
AMP Validator feature to support disallowed ancestor tags.
@Gregable Gregable merged commit a333001 into ampproject:master Dec 17, 2015
@Gregable Gregable deleted the ancestor branch December 17, 2015 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants