Delegate to viewer for cid generation if AMP is embedded. #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to ampproject#961. Only missing item it that the viewer needs to actually respond. Wraps localStorage access in try-blocks, because it may fail. Fixes ampproject#1148
cramforce
force-pushed
the
localstorage
branch
from
17a92ab
to
fdbc162
Compare
|
LGTM for viewer integration |
|
LGTM |
|
One question: is this intended to only iframe'd cases? Or potentially WebView case as well? |
cramforce
added a commit
that referenced
this pull request
Dec 14, 2015
Delegate to viewer for cid generation if AMP is embedded.
|
Not sure we need it in webview. Can definitely address separately.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #961. Only missing item it that the viewer needs to actually respond.
Wraps localStorage access in try-blocks, because it may fail. Fixes #1148