Implement URL replacement for client ids available to amp-analytics #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| image.height = 1; | ||
| // Make it take zero space | ||
| this.element.style.width = 0; | ||
| this.element.appendChild(image); |
There was a problem hiding this comment.
Why are we even adding image to DOM?
There was a problem hiding this comment.
If any reason, just for testing. No good reason to change in this CL.
|
PTAL |
|
LGTM |
…them to `amp-analytics`. Also makes the following changes - Switches `amp-analytics` to use layoutCallback instead of `buildCallback`. Closes ampproject#1141 and makes the tests more straight forward since they are now async. - Support for promised based URL replacement - Support for (right now only one) arguments to URL replacement functions. Related to ampproject#961 ampproject#871 Fixes ampproject#1124
cramforce
added a commit
that referenced
this pull request
Dec 12, 2015
Implement URL replacement for client ids available to amp-analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the following changes
amp-analyticsto use layoutCallback instead ofbuildCallback. Closes amp-analytics should use layoutCallback instead of buildCallback #1141 and makes the tests more straight forward since they are now async.Related to #961 #871
Fixes #1124