Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to the templates component of the validator. #1145

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Minor fixes to the templates component of the validator. #1145

merged 1 commit into from
Dec 11, 2015

Conversation

Gregable
Copy link
Member

These seem to be working without the fix, but let's get this cleaned up.

For some reason, calling parsedSpec.valueHasUnescapedTemplateSyntax seems to
work, even though parsedSpec is a ParsedAttrSpec and
valueHasUnescapedTemplateSyntax is only defined on ParsedTagSpec. Our only
theory is that closure has a bug which is making this function a global, since
it doesn't access any member variables. This only works in some contexts, though.

…o be

working without the fix, but let's get this cleaned up.

For some reason, calling parsedSpec.valueHasUnescapedTemplateSyntax seems to
work, even though parsedSpec is a ParsedAttrSpec and
valueHasUnescapedTemplateSyntax is only defined on ParsedTagSpec. Our only
theory is that closure has a bug which is making this function a global, since
it doesn't access any member variables. This only works in some contexts,
though.
@@ -1286,6 +1286,11 @@ ParsedTagSpec.prototype.getSpec = function() {
return this.spec_;
};

/**
* Returns true if |value| contains a mustache unescaped template syntax.
* @param {!string} value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string is already !.

@dvoytenko
Copy link
Contributor

LGTM

@dvoytenko dvoytenko added the LGTM label Dec 11, 2015
Gregable added a commit that referenced this pull request Dec 11, 2015
Minor fixes to the templates component of the validator.
@Gregable Gregable merged commit fac5647 into ampproject:master Dec 11, 2015
@Gregable Gregable deleted the fixtemplates branch June 20, 2016 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants