Minor fixes to the templates component of the validator. #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be working without the fix, but let's get this cleaned up. For some reason, calling parsedSpec.valueHasUnescapedTemplateSyntax seems to work, even though parsedSpec is a ParsedAttrSpec and valueHasUnescapedTemplateSyntax is only defined on ParsedTagSpec. Our only theory is that closure has a bug which is making this function a global, since it doesn't access any member variables. This only works in some contexts, though.
| @@ -1286,6 +1286,11 @@ ParsedTagSpec.prototype.getSpec = function() { | |||
| return this.spec_; | |||
| }; | |||
|
|
|||
| /** | |||
| * Returns true if |value| contains a mustache unescaped template syntax. | |||
| * @param {!string} value | |||
|
LGTM |
Gregable
added a commit
that referenced
this pull request
Dec 11, 2015
Minor fixes to the templates component of the validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to be working without the fix, but let's get this cleaned up.
For some reason, calling parsedSpec.valueHasUnescapedTemplateSyntax seems to
work, even though parsedSpec is a ParsedAttrSpec and
valueHasUnescapedTemplateSyntax is only defined on ParsedTagSpec. Our only
theory is that closure has a bug which is making this function a global, since
it doesn't access any member variables. This only works in some contexts, though.