Updating amp-twitter exmaple with more accurate content height #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paul-matthews
commented
Dec 11, 2015
paul-matthews
commented
- Using more accurate heights for tweets
- 472 for image tweets
- 330 for regular tweets
* Using more accurate heights for tweets * 472 for image tweets * 330 for regular tweets
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 1e9da21 (Please note that this is a fully automated comment.) |
|
Looks good to me, Thank you for fixing! -michael ducker, Twitter |
|
Thanks. LGTM. Test seems to be a flake. |
cramforce
added a commit
that referenced
this pull request
Dec 11, 2015
Updating amp-twitter exmaple with more accurate content height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.