Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Validation big pieces #1142

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Template Validation big pieces #1142

merged 1 commit into from
Dec 11, 2015

Conversation

Gregable
Copy link
Member

Basic validation relaxations required for validating mustache templates:

  • allow <template> tag
  • allow corresponding <script> tag

Some lightweight validation errors not designed to catch all issues, but to guide the developer:

  • disallow mustache characters { and } in data- attributes.
  • disallow unescaped variables {{{var}}} and {{{&var}}} syntax in all attribute values
  • disallow partials {{>partial}}} syntax in all attribute values.

Not a final implementation, but should be usable as written, I think.

Related to #892

@powdercloud
Copy link
Contributor

LGTM

Gregable added a commit that referenced this pull request Dec 11, 2015
 Template Validation big pieces
@Gregable Gregable merged commit 1f78f94 into ampproject:master Dec 11, 2015
@Gregable Gregable deleted the templates branch December 11, 2015 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants