Install templates service right away #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvoytenko LGTM |
dvoytenko
added a commit
that referenced
this pull request
Dec 10, 2015
Install templates service right away
| @@ -49,6 +50,7 @@ try { | |||
| installHistoryService(window); | |||
| viewerFor(window); | |||
| vsyncFor(window); | |||
| templatesFor(window); | |||
There was a problem hiding this comment.
Don't understand this: Why do we need templates in core?
There was a problem hiding this comment.
They were always compiled in because runtime.js registers the AMP.registerTemplate function. The issue was that depending on download order, either the core's templates service would be installed (if template implementation is downloads first and calls AMP.registerTemplate) or another version, downloaded with amp-list or similar using element, would be installed first. I didn't like this ambiguity. This is subject to the service/implementation refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since templates are always compiled into base runtime, there's no real cost to install right away, rather risk the custom element override it.