Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Moving viewer.js into own service, still buggy #1122

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/amp.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@

import './polyfills';

import {installViewerService} from './service/viewer-impl';
import {installHistoryService} from './service/history-impl';
import {installPullToRefreshBlocker} from './pull-to-refresh';
import {performanceFor} from './performance';
import {viewerFor} from './viewer';
import {vsyncFor} from './vsync';
import {templatesFor} from './template';

Expand Down Expand Up @@ -47,8 +47,8 @@ try {
perf.tick('is');
installStyles(document, cssText, () => {
try {
installViewerService(window);
installHistoryService(window);
viewerFor(window);
vsyncFor(window);
templatesFor(window);

Expand Down
2 changes: 2 additions & 0 deletions src/history.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

import {getElementService} from './service';

/**
* Returns service implemented in service/history-impl.
* @param {!Window} window
Expand Down
2 changes: 2 additions & 0 deletions src/service/history-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@
* limitations under the License.
*/

import {installViewerService} from '../service/viewer-impl';
import {Pass} from '../pass';
import {assert} from '../asserts';
import {getService} from '../service';
import {log} from '../log';
import {timer} from '../timer';
import {viewerFor} from '../viewer';

installViewerService(window);

/** @private @const */
const TAG_ = 'History';
Expand Down
Loading