Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating amp-analytics comScore parameters #11054

Merged
merged 2 commits into from
Aug 24, 2017

Conversation

acorretti-comscore
Copy link
Contributor

  • Add pageViewId (cs_pv)
  • Add clientId(comScore) (c12)

* Add pageViewId (cs_pv)
* Add clientId(comScore) (c12)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Copy link
Contributor

@avimehta avimehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acorretti-comscore
Copy link
Contributor Author

Thanks @avimehta, I've updated the tests accordingly.
Do you prefer me to send a new PR or can you squash commits on this one?

Copy link
Contributor

@avimehta avimehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you had authored the original comscore tag. Based on that, this PR looks good to me.

@avimehta
Copy link
Contributor

@acorretti You don't need to squash the commits but it looks like CLA check is not passing yet. Can you go through the GoogleBot comment and see if you can resolve the CLA issue?

@acorretti-comscore
Copy link
Contributor Author

@avimehta I did fulfill the CLA agreement in the name of comScore, Inc. to be signed by my manager Thomas Pottjegort. He signed it earlier this evening, but I don't know how to tell the GoogleBot about that.

@acorretti-comscore
Copy link
Contributor Author

Let's see if the CLA bot can find our CLA now.

@googlebot
Copy link

CLAs look good, thanks!

@jridgewell jridgewell merged commit ff97a8e into ampproject:master Aug 24, 2017
@avimehta
Copy link
Contributor

@acorretti Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants