-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Sauce runs on IE on an opt-in basis #11030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets opt in at least one test.
Opted in amp-bind tests. |
@choumx, we now have a working solution for sauce labs testing on IE. See PR description for details. I've gone ahead and enabled a few integration tests like |
@choumx, @cramforce, we now have IE 11 in our browser matrix. I've enabled a bunch of tests on IE 11: see https://travis-ci.org/ampproject/amphtml/jobs/267750202 This PR is ready for review. |
Comments have been addressed.
All comments are addressed, and we now have more than a dozen tests running and passing on IE 11. Merging this PR. |
This PR does the following:
enableIe
andifIe
to allow test writers to opt in to testing on IEdescribe(
withdescribe().configure().run(
, so that the new defaultTestConfig
is picked upIn the new world:
describe('foo')
is no longer meant to be used for integration tests (if used, it will include IE)describe().configure().run()
will run tests on all browsers except IEdescribe().configure().enableIe().run()
will run tests on all browsers including IEdescribe().configure().ifIe().run()
will run tests only on IEFixes #10731