-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator should flag missing script tags #875
Comments
Yes! We were tracking this already, but I can't find the issue. |
@cramforce Is there any estimate for when the validator will be open sourced? |
No, but before Christmas :) Maybe in a few days.
|
Follow up question on this issue. Is there a good reason to flag the opposite relationship: a This represents a small performance hit, but is otherwise not a big deal? I would imagine requiring it would break some pages where the site owner includes the superset of all imports needed by any page on the site into a reused template, so my initial thought is that this would be a bad idea to make bidirectional. |
Require a specific version of each custom element. Implement dispatch keys to associate error messages with the correct tagspec. Require script import for each custom element. Github Issue ampproject#875
The validator now flags these missing script tags. Let me know if you see any issues with it. |
I've run into a couple of cases where I've used AMP HTML tags without their corresponding
script
"imports," but the validator doesn't catch it. For example, in you insert an animated GIF using amp-anim (without the corresponding amp-amin JavaScript tag), the placeholder will be rendered (presumably since the amp-img implementation is in AMP core), but the validator doesn't flag the missing JavaScript tag.The text was updated successfully, but these errors were encountered: