Skip to content

defend against variable declaration issue #39383

Open
@erwinmombay

Description

Description

Figure out how we can prevent #39381, #39380

the issue cropped itself up in our module build but is non an issue in our nomodule build (because of function scoping)

Look into https://eslint.org/docs/latest/rules/no-redeclare if we can use this lint rule to prevent the issue

also look into why our tests was not able to catch the issue

Reproduction Steps

re introduce this renaming bug
54c0400

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions