Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp story shopping] Price discount / badge #37949

Open
processprocess opened this issue Mar 24, 2022 · 2 comments
Open

[amp story shopping] Price discount / badge #37949

processprocess opened this issue Mar 24, 2022 · 2 comments

Comments

@processprocess
Copy link
Contributor

processprocess commented Mar 24, 2022

Description

Enable a slashed out price.

Screen Shot 2022-03-24 at 2 40 20 PM

An originalPrice field could be added to the config. "price" seems like it should always be the active price.

Badge UX will need to be finalized. This could be a set list of strings like "discounted" or "two days only".

Look into possibility of updating this like amp-list, where it only updates a section of the data so it's always up-to-date.
This can be accomplished by using a src attribute and updating the data but there is interest in understanding if just a piece of the template can be updated.

The recommended approach for this is to use the src attribute instead of updating the inline JSON.

@cpauwels
Copy link
Contributor

@processprocess IMO if the customer wants the up to date price, they can set a src on the <amp-story-shopping-attachment> and leave the inline JSON as a fallback. Also easier to maintain since it's only one endpoint instead of two (one for the product, the other one for the price)

@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants