-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta I2D: Deprecate Periodic Asia/Oceania Design Reviews #36888
Comments
design review feedback Instead of the plan above, pursue a slower deprecation path:
|
Thanks for taking these notes @samouri. The updated approach looks great to me. Can you work with @alanorozco to alter scripts to match? |
Alan had completed the PR that updates the scripts before I had even finished presenting 😄 |
Whoa! Amazing. Nice work @alanorozco! |
Our documentation states I need at least 3 approval from @ampproject/wg-approvers for I2Ds (or maybe just "significant changes"?). |
+1, I approve this change. Thanks for improving the usefulness of our design review meetings, @samouri and @alanorozco! |
Approved |
Closing as the timezone has been removed from the rotation after the 2nd cancelled one. |
Context
The AMP Projects holds public weekly design reviews on Wednesdays. In order to be inclusive of our global network of AMP Contributors, we cycle the timezone of the meeting between one convenient for Americas, Asia/Oceania, and Africa/Europe/western Asia.
We've historically had incredibly poor attendance for Asia/Oceania reviews. This is a problem because design reviews are only useful if we have a sizable number of folks to give guidance and help make decisions.
Proposal
Remove the the Asia/Oceania design review from our weekly rotation as well as update the guidance in our documentation for how to create ad-hoc meetings.
Our current documentation says:
We should improve this s.t. we don't have a single point-of-contact.
We can create a
#design-review
channel on Slack for folks to reach out on. Through that channel we can schedule design reviews and ensure appropriate reviewers.Deprecation Plan
Notifications
@ampproject/wg-approvers
The text was updated successfully, but these errors were encountered: