Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta I2D: Deprecate Periodic Asia/Oceania Design Reviews #36888

Closed
samouri opened this issue Nov 10, 2021 · 8 comments
Closed

Meta I2D: Deprecate Periodic Asia/Oceania Design Reviews #36888

samouri opened this issue Nov 10, 2021 · 8 comments
Assignees
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature.

Comments

@samouri
Copy link
Member

samouri commented Nov 10, 2021

Context

The AMP Projects holds public weekly design reviews on Wednesdays. In order to be inclusive of our global network of AMP Contributors, we cycle the timezone of the meeting between one convenient for Americas, Asia/Oceania, and Africa/Europe/western Asia.

We've historically had incredibly poor attendance for Asia/Oceania reviews. This is a problem because design reviews are only useful if we have a sizable number of folks to give guidance and help make decisions.

Proposal

Remove the the Asia/Oceania design review from our weekly rotation as well as update the guidance in our documentation for how to create ad-hoc meetings.

Our current documentation says:

If none of the design review times are convenient for you and you have a design you would like to discuss please reach out to mrjoro on Slack.

We should improve this s.t. we don't have a single point-of-contact.
We can create a #design-review channel on Slack for folks to reach out on. Through that channel we can schedule design reviews and ensure appropriate reviewers.

Deprecation Plan

  1. Created a dedicated slack channel for design review questions/requests.
  2. Modify our design review documentation to recommend reaching out on the new channel.
  3. Modify our scripts to stop generating Design Review issues for Asia/Oceania timezone.

Notifications

@ampproject/wg-approvers

@samouri samouri added the INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. label Nov 10, 2021
@samouri samouri changed the title I2D: Deprecate Periodic Asia/Oceania Design Reviews Meta I2D: Deprecate Periodic Asia/Oceania Design Reviews Nov 10, 2021
@samouri samouri self-assigned this Nov 11, 2021
@samouri
Copy link
Member Author

samouri commented Dec 1, 2021

design review feedback

Instead of the plan above, pursue a slower deprecation path:

  1. Still create dedicated slack channel, which may be useful for other situations as well e.g. unblocking folks during periods of high rate of design reviews. Also update the documentation from "contact mrjoro".
  2. Instead of removing Asia/Oceania from our rotation, reduce its frequency to 1/3rd of its current cadence. If two in a row have nobody request a design review, then fully remove from rotation. else keep it at the reduced cadence.

@kristoferbaxter
Copy link
Contributor

Thanks for taking these notes @samouri. The updated approach looks great to me.

Can you work with @alanorozco to alter scripts to match?

@samouri
Copy link
Member Author

samouri commented Dec 1, 2021

Can you work with @alanorozco to alter scripts to match?

Alan had completed the PR that updates the scripts before I had even finished presenting 😄

@kristoferbaxter
Copy link
Contributor

Whoa! Amazing. Nice work @alanorozco!

@samouri
Copy link
Member Author

samouri commented Dec 2, 2021

Our documentation states I need at least 3 approval from @ampproject/wg-approvers for I2Ds (or maybe just "significant changes"?).
Is that still true? If so I'll hold off until I have two more approvals.

@rsimha
Copy link
Contributor

rsimha commented Dec 6, 2021

+1, I approve this change. Thanks for improving the usefulness of our design review meetings, @samouri and @alanorozco!

@jridgewell
Copy link
Contributor

Approved

@samouri
Copy link
Member Author

samouri commented Feb 8, 2022

Closing as the timezone has been removed from the rotation after the 2nd cancelled one.

@samouri samouri closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature.
Projects
None yet
Development

No branches or pull requests

4 participants