Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for shadow dom #20044

Open
jpettitt opened this issue Dec 21, 2018 · 8 comments
Open

Add integration test for shadow dom #20044

jpettitt opened this issue Dec 21, 2018 · 8 comments

Comments

@jpettitt
Copy link
Contributor

We've had multiple issues with DOM inconsistencies when AMP code is imported through a shadow dom based mechanism (in Polymer ), see list below. We need some shadow dom integration tests.

Here some of the issues:
#19434 amp-experiment
#19694 amp-subscriptions-google
#12912 amp-ads
#12388 amp-img
#12151 amp-list
#10799 amp-access

@justforfun
Copy link

Here is another one:
#20008

@justforfun
Copy link

We a brand new issue of the same kind:
#20400

@jpettitt
Copy link
Contributor Author

Is this on the roadmap?

cc @rudygalfi

@rudygalfi
Copy link
Contributor

@rsimha let us know your thoughts here.

@prateekbh prateekbh self-assigned this May 22, 2019
@rsimha
Copy link
Contributor

rsimha commented Jul 16, 2019

I think this can be covered by E2E tests now. @prateekbh Can you comment?

@prateekbh
Copy link
Member

Yes, I had a conversation around the same and definitely looks like this can be done via e2e tests

@prateekbh prateekbh removed their assignment Aug 6, 2019
@stale
Copy link

stale bot commented Jan 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jan 27, 2021
@rsimha rsimha removed their assignment Jan 27, 2021
@stale stale bot removed the Stale Inactive for one year or more label Jan 27, 2021
@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants