Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox + amp-img + Polymer not rendering properly #12388

Closed
cvializ opened this issue Dec 9, 2017 · 15 comments
Closed

Firefox + amp-img + Polymer not rendering properly #12388

cvializ opened this issue Dec 9, 2017 · 15 comments
Labels
Milestone

Comments

@cvializ
Copy link
Contributor

cvializ commented Dec 9, 2017

In Firefox, amp-img might be misbehaving either when loaded by shadow-v0.js and/or when rendered inside a Polymer app.

Example: https://amp-by-example-staging.appspot.com/polymer/detail/introduction/hello_world/

Split off from #12132

/cc @kul3r4 @aghassemi

@kul3r4
Copy link
Contributor

kul3r4 commented Dec 9, 2017

https://amp-by-example-staging.appspot.com/introduction/hello_world/ on Firefox is now working for me.

If you look at: https://rep.repubblica.it/pwa/intervista/2017/12/08/news/laura_boldrini_leggi_e_condivisione_di_valori_contro_il_neofascismo-183530302/ is also loading the image, but if you arrive to the page via a navigation, from https://rep.repubblica.it/ click on where it says "Boldrini", then the head image does not load.

@justforfun FYI

@justforfun
Copy link

@kul3r4 : The only difference I can see comparing the console logs of the two cases is that when you load directly the URL the following message appears:

Powered by AMP ⚡ HTML shadows – Version 1512677960104 viewer-impl.js:1050:38

@kul3r4
Copy link
Contributor

kul3r4 commented Dec 9, 2017

@justforfun Sorry, I was testing the wrong URL, I am still able to reproduce it on https://amp-by-example-staging.appspot.com/polymer/detail/introduction/hello_world/. This only happens when landing on the page via navigation, while the page works if you just load the URL, same thing as it happens on rep.repubblica.it.

@justforfun
Copy link

If it can be of any help, it seems that the problem is not occurring in an pwa based on Polymer 1.
For instance this is the list page:
https://pwa-news.appspot.com/list/chrome
and this a detail linked from this page:
https://pwa-news.appspot.com/article/chrome/test-rep-ff

@rudygalfi
Copy link
Contributor

We haven't lost track of this, but are still awaiting some folks returning from holidays who could take a look.

@kul3r4
Copy link
Contributor

kul3r4 commented Jan 10, 2018

@justforfun I just tried the following:

Could you confirm this bug is still happening?

@cvializ
Copy link
Contributor Author

cvializ commented Jan 10, 2018

I attempted to reproduce yesterday and today and I was unable. Are you aware of anything that changed on your end to resolve the problem?

@justforfun
Copy link

justforfun commented Jan 11, 2018

I'm not able to reproduce the bug anymore but on the FF browser console I see the error:
g is not a function
raised here
https://cdn.ampproject.org/shadow-v0.js:81:490
and here
https://cdn.ampproject.org/rtv/011515614886756/v0/amp-access-0.1.js:14:427

schermata 2018-01-11 alle 14 40 51

The error doesn't occur on Chrome

@cvializ
Copy link
Contributor Author

cvializ commented Jan 12, 2018

I can reproduce that error, but I have not yet found the root cause. It looks like an event polyfill in Polymer that runs for firefox but not chrome might be related to the problem

@cvializ
Copy link
Contributor Author

cvializ commented Jan 19, 2018

I will close this issue for now. If the new error is still occurring for you please open a new issue so we can track it.

@cvializ cvializ closed this as completed Jan 19, 2018
@kul3r4
Copy link
Contributor

kul3r4 commented Feb 13, 2018

@cvializ could you please reopen this as it is still happening

@cvializ cvializ reopened this Feb 16, 2018
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @cvializ Do you have any updates?

@aghassemi aghassemi assigned danielrozenberg and unassigned cvializ Jun 19, 2018
@aghassemi
Copy link
Contributor

/to @danielrozenberg

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @danielrozenberg Do you have any updates?

@stale
Copy link

stale bot commented Dec 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 11, 2020
@stale stale bot closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants