-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with running ads from a custom domain #1526
Comments
This happens when opted into canary release. You can fix this on your side by amending the
in remote.html to be
We will update the documentation. |
@NataliaLKB Could you confirm that this fixed things for you? |
Will be able to confirm momentarily |
We will need to be careful in the future about extending the format of the version string. Fixes #1526
Unfortunately it doesn't seem to have solved the problem, any other ideas? |
Looking at https://www.theguardian.com/books/booksblog/2016/jan/20/the-best-music-to-listen-to-while-reading-or-is-it-sacrilege/amp I now see one add loading, but there seems to be a JS error in your own Krux related code. Could that be the problem? |
I will check with that team, as it does seem to be an error there. Thanks @cramforce . Will close this issue. |
There seems to be an issue when following these guidelines.
All iframes on the page seem to be affected. Amp-twitter for example is broken. Specifically the iframe it creates.
Here is a screenshot of how amp-twitter is being affected:
Here is the example page:
https://www.theguardian.com/books/booksblog/2016/jan/20/the-best-music-to-listen-to-while-reading-or-is-it-sacrilege/amp
cc @kenlim @stephanfowler
The text was updated successfully, but these errors were encountered: