-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use listenOnce in amp-story #13159
Comments
This issue hasn't been updated in awhile. Do you have any updates? |
This is a code cleanup that can happen during a fixit. |
I can work on this one |
Sure! Thanks @juanlizarazo! |
@newmuis I attempted to use So instead, I refactored this with listen and stored the unlisteners than then are called in unlayoutCallback. PR #17004 is ready for review. c.c. @mrjoro |
After looking at @juanlizarazo's investigation, I think we actually don't want the behavior mentioned in the original report at all. Closing this issue. |
We have many places in
amp-story
code that add an event listener but do not remove it. For this, we can refactor to uselistenOnce
.The text was updated successfully, but these errors were encountered: