-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amp-font: Unhandled Promise Rejection #1095
Comments
Thanks for the report! Assigning to @sriramkrish85 |
@NataliaLKB , You are seeing this error because the font takes too long to download (default is 3s), if you want you can set a timeout attribute > 3000 and see if it loads. I will send a PR soon that will have an warning (rather than an error) that is easy to read. |
Yes, making this a warning sounds good. And lets spell out exactly what On Tue, Dec 8, 2015 at 7:47 PM Sriram Krishnan notifications@github.com
|
Amp-font: Un-handled Promise Rejection #1095
@NataliaLKB - Made a console.warn - to give some useful message. Let me know if you are able to get the font to load after increasing your timeout. Closing this issue for now. Feel free to re-open if required. |
@sriramkrish85 thanks so much for taking a look. The first thing I tried is increasing the timeout to 10s (10000). Loading the font through Can you think of anything else to try, or that I may have done wrong? |
@NataliaLKB , you will have to use the
to be able to use amp-font efficiently You can take a look at examples/font.amp.html for usage and give it another shot, or ping me a gist of what you are trying and i would be happy to take a look. |
@sriramkrish85 currently on the page referenced above I have:
Locally I have tried it with 100s |
Bug fix #1095 - fix font-size for comparison.
@NataliaLKB , thanks for the link to help debug the issue. I have pushed a fix. You should be good now (I also saw that this was already working on mobile safari without my fixes. My fixes would make this more stable.) |
we need to do a release btw if we want them to receive the fix. |
@NataliaLKB latest release should be out within the hour https://github.com/ampproject/amphtml/releases |
That is great! Thank you so much!
|
Just tested it out, and it works great now. Thank you 😄 |
When trying out amp-font, I receive an error:
The font works fine when used regularly (just using
font-face
).Is this an error you could help me with? The test page is here
The text was updated successfully, but these errors were encountered: