🏗 Clean up validator C++ logs and surface errors (#33910)

ampproject · Apr 20, 2021 · e66c72f · e66c72f
1 parent 84a91a8
commit e66c72f
Showing 1 changed file with 19 additions and 10 deletions.
diff --git a/build-system/tasks/validator.js b/build-system/tasks/validator.js
@@ -24,7 +24,7 @@ if (argv.update_tests) {
 }
 
 /**
- * Simple wrapper around the python based validator build.
+ * Simple wrapper around the python based validator tests.
  */
 async function validator() {
   execOrDie('python3 build.py' + validatorArgs, {
@@ -34,20 +34,29 @@ async function validator() {
 }
 
 /**
- * Simple wrapper around the C++ validator tests
+ * Simple wrapper around the bazel based C++ validator tests.
  */
 async function validatorCpp() {
-  execOrDie(
-    `bazel test --repo_env=CC=clang --cxxopt='-std=c++17' validator_test`,
-    {
-      cwd: 'validator/cpp/engine',
-      stdio: 'inherit',
-    }
-  );
+  const bazelCmd = [
+    'bazel test',
+    '--repo_env=CC=clang',
+    "--cxxopt='-std=c++17'",
+    '--test_output=errors',
+    '--ui_event_filters=INFO',
+    '--noshow_progress',
+    '--noshow_loading_progress',
+    '--test_summary=detailed',
+    '--verbose_failures',
+    'validator_test',
+  ].join(' ');
+  execOrDie(bazelCmd, {
+    cwd: 'validator/cpp/engine',
+    stdio: 'inherit',
+  });
 }
 
 /**
- * Simple wrapper around the python based validator webui build.
+ * Simple wrapper around the python based validator webui tests.
  */
 async function validatorWebui() {
   execOrDie('python3 build.py' + validatorArgs, {