Skip to content

Commit

Permalink
Fix dangling TODO in cut-nightly.yml (#40070)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielrozenberg authored Jul 31, 2024
1 parent 9d9d9f8 commit dd6fe32
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions build-system/release-workflows/cut-nightly.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,11 @@ async function getCommit(octokit) {

for (const {sha} of commits.data) {
const checkRuns = (
await octokit.paginate(
// TODO(danielrozenberg): seems to be related to https://github.com/octokit/plugin-paginate-rest.js/issues/350
// restore this when the types match again: await octokit.rest.checks.listForRef,
'GET /repos/{owner}/{repo}/commits/{ref}/check-runs',
{
...params,
ref: sha,
'per_page': 100,
}
)
await octokit.paginate(octokit.rest.checks.listForRef, {
...params,
ref: sha,
'per_page': 100,
})
).filter(
({'external_id': id, name}) =>
id !== GITHUB_EXTERNAL_ID && !CHECKS_TO_SKIP.includes(name)
Expand Down

0 comments on commit dd6fe32

Please sign in to comment.