Skip to content

Commit

Permalink
Add amp-ad type sharethrough (#3036)
Browse files Browse the repository at this point in the history
* Add amp-ad type sharethrough

* Update documentation to show pkey required
  • Loading branch information
nuclearghost authored and dvoytenko committed Apr 29, 2016
1 parent 934d2e7 commit cfb22ca
Show file tree
Hide file tree
Showing 5 changed files with 75 additions and 0 deletions.
2 changes: 2 additions & 0 deletions 3p/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import {gmossp} from '../ads/gmossp';
import {weboramaDisplay} from '../ads/weborama';
import {adstir} from '../ads/adstir';
import {colombia} from '../ads/colombia';
import {sharethrough} from '../ads/sharethrough';
import {eplanning} from '../ads/eplanning';


Expand Down Expand Up @@ -118,6 +119,7 @@ register('weborama-display', weboramaDisplay);
register('yieldbot', yieldbot);
register('adstir', adstir);
register('colombia', colombia);
register('sharethrough', sharethrough);
register('eplanning', eplanning);

// For backward compat, we always allow these types without the iframe
Expand Down
28 changes: 28 additions & 0 deletions ads/sharethrough.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/**
* Copyright 2016 The AMP HTML Authors. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS-IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import {writeScript, checkData, validateDataExists} from '../src/3p';

/**
* @param {!Window} global
* @param {!Object} data
*/
export function sharethrough(global, data) {
checkData(data, ['pkey']);
validateDataExists(data, ['pkey']);
global.pkey = data.pkey;
writeScript(global, 'https://native.sharethrough.com/iframe/amp.js');
}
37 changes: 37 additions & 0 deletions ads/sharethrough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<!---
Copyright 2016 The AMP HTML Authors. All Rights Reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS-IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->

# Sharethrough

## Example

### Basic

```html
<amp-ad width=300 height=450
layout="responsive"
type="sharethrough"
data-pkey="c0fa8367">
</amp-ad>
```

## Configuration

For semantics of configuration, please [contact Sharethrough](mailto:pubsupport@sharethrough.com).

Required Parameters:

- ```data-pkey``` (String, non-empty) The unique identifier for your placement
1 change: 1 addition & 0 deletions builtins/amp-ad.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ resources in AMP. It requires a `type` argument that select what ad network is d
- [PubMatic](../ads/pubmatic.md)
- [Revcontent](../ads/revcontent.md)
- [Rubicon Project](../ads/rubicon.md)
- [Sharethrough](../ads/sharethrough.md)
- [Smart AdServer](../ads/smartadserver.md)
- [Sortable](../ads/sortable.md)
- [TripleLift](../ads/triplelift.md)
Expand Down
7 changes: 7 additions & 0 deletions examples/ads.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,13 @@ <h2>Colombia ad</h2>
data-clmb_section="0">
</amp-ad>

<h2>Sharethrough</h2>
<amp-ad width=300 height=150
layout="responsive"
type="sharethrough"
data-pkey="c0fa8367">
</amp-ad>

<h2>E-Planning 320x50</h2>
<amp-ad width=320 height=50
type="eplanning"
Expand Down

0 comments on commit cfb22ca

Please sign in to comment.