🏗 Prevent Karma from hanging when a transformation error is encounter…

…ed (#33967)
ampproject · Apr 24, 2021 · c0e946a · c0e946a
1 parent d33dbca
commit c0e946a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/build-system/tasks/report-test-status.js b/build-system/tasks/report-test-status.js
@@ -209,11 +209,12 @@ async function reportAllExpectedTests() {
 
 /**
  * Callback to the Karma.Server on('run_complete') event for simple test types.
+ * Optionally takes an object containing test results if they were run.
  *
- * @param {!Karma.TestResults} results
+ * @param {?Karma.TestResults} results
  */
 async function reportTestRunComplete(results) {
-  if (results.error) {
+  if (!results || results.error) {
     await reportTestErrored();
   } else {
     await reportTestFinished(results.success, results.failed);

diff --git a/build-system/tasks/runtime-test/helpers.js b/build-system/tasks/runtime-test/helpers.js
@@ -20,7 +20,7 @@ const fs = require('fs');
 const path = require('path');
 const {green, yellow, cyan} = require('kleur/colors');
 const {isCiBuild} = require('../../common/ci');
-const {log} = require('../../common/logging');
+const {log, logWithoutTimestamp} = require('../../common/logging');
 const {maybePrintCoverageMessage} = require('../helpers');
 const {reportTestRunComplete} = require('../report-test-status');
 const {Server} = require('karma');
@@ -172,7 +172,7 @@ async function karmaBrowserComplete_(browser) {
  * @private
  */
 function karmaBrowserStart_() {
-  console./*OK*/ log('\n');
+  logWithoutTimestamp('\n');
   log(green('Done. Running tests...'));
 }
 

diff --git a/build-system/tasks/runtime-test/runtime-test-base.js b/build-system/tasks/runtime-test/runtime-test-base.js
@@ -399,11 +399,9 @@ class RuntimeTestRunner {
     await stopServer();
     exitCtrlcHandler(this.env.get('handlerProcess'));
     if (this.exitCode != 0) {
-      log(
-        red('ERROR:'),
-        yellow(`Karma test failed with exit code ${this.exitCode}`)
-      );
-      process.exitCode = this.exitCode;
+      const message = `Karma test failed with exit code ${this.exitCode}`;
+      log(red('ERROR:'), yellow(message));
+      throw new Error(message);
     }
   }
 }