convert null checks into attribute declarations

ampproject · May 5, 2021 · adda7f0 · adda7f0
1 parent 2b36ebb
commit adda7f0
Show file tree

Hide file tree

Showing 4 changed files with 603 additions and 199 deletions.
diff --git a/build-system/tasks/runtime-test/runtime-test-base.js b/build-system/tasks/runtime-test/runtime-test-base.js
@@ -53,28 +53,24 @@ let wrapCounter = 0;
  */
 let transform;
 
-/**
- * @extends {karmaConfig}
- */
 class RuntimeTestConfig {
+  /** @type {Array<string|[]>} */
+  plugins = [];
+
+  /**@type {Record<string, string|string[]>} */
+  preprocessors = {};
+
+  /** @type {string[]} */
+  reporters = [];
+
+  client = {};
+
   /**
    * @param {string} testType
    */
   constructor(testType) {
     this.testType = testType;
     Object.assign(this, karmaConfig);
-    if (!this.plugins) {
-      this.plugins = [];
-    }
-    if (!this.preprocessors) {
-      this.preprocessors = [];
-    }
-    if (!this.reporters) {
-      this.reporters = [];
-    }
-    if (!this.client) {
-      this.client = {};
-    }
     this.updateBrowsers();
     this.updateReporters();
     this.updateFiles();
@@ -84,6 +80,7 @@ class RuntimeTestConfig {
     this.updateMiddleware();
     this.updateCoverageSettings();
   }
+
   /**
    * Updates the set of preprocessors to run on HTML and JS files before testing.
    * Notes:

diff --git a/build-system/test-configs/karma.conf.js b/build-system/test-configs/karma.conf.js
@@ -31,9 +31,6 @@ if (argv.debug) {
   COMMON_CHROME_FLAGS.push('--auto-open-devtools-for-tabs');
 }
 
-/**
- * @param {!Object} config
- */
 module.exports = {
   frameworks: ['fixture', 'mocha', 'source-map-support'],