Skip to content

Commit

Permalink
🐛 [amp-analytics-vendor] Small change to the vendor blueconic.json to…
Browse files Browse the repository at this point in the history
… get better analytics results (#37334)

* Changes to the blueconic.json

* Added properties to the defaultTrackingValues and trackingValuesWithoutGeo

* Fixed the failing unit test
  • Loading branch information
bc-stef authored Jan 31, 2022
1 parent ccf1f0f commit a215d7b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion extensions/amp-analytics/0.1/test/vendor-requests.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
"blueconic": {
"event": "https://!tenantId/s/!pixelId.gif?",
"trackingIdentifier": "https://!tenantId/s/!pixelId.gif?property=!property&!property=_client_id(cid-scope-cookie-fallback-name)_!extraTrackingValues",
"defaultTrackingValues": "https://!tenantId/s/!pixelId.gif?property=!property&!property=_client_id(cid-scope-cookie-fallback-name)_!extraTrackingValues&sourceUrl=_source_url_&canonicalUrl=_canonical_url_&referrer=_document_referrer_&title=_title_&visitDate=_timestamp_&geoLocation=_amp_geo(ISOCountry)_&userAgent=_user_agent_"
"defaultTrackingValues": "https://!tenantId/s/!pixelId.gif?property=!property&!property=_client_id(cid-scope-cookie-fallback-name)_!extraTrackingValues&sourceUrl=_source_url_&canonicalUrl=_canonical_url_&referrer=_document_referrer_&title=_title_&visitDate=_timestamp_&geoLocation=_amp_geo(ISOCountry)_&userAgent=_user_agent_&canonicalHostname=_canonical_hostname_&deviceType=!deviceType&originType=!originType",
"trackingValuesWithoutGeo": "https://!tenantId/s/!pixelId.gif?property=!property&!property=_client_id(cid-scope-cookie-fallback-name)_!extraTrackingValues&sourceUrl=_source_url_&canonicalUrl=_canonical_url_&referrer=_document_referrer_&title=_title_&visitDate=_timestamp_&userAgent=_user_agent_&canonicalHostname=_canonical_hostname_&deviceType=!deviceType&originType=!originType"
},
"bluetriangle": {
"host": "https://d.btttag.com",
Expand Down
3 changes: 2 additions & 1 deletion extensions/amp-analytics/0.1/vendors/blueconic.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"requests": {
"event": "https://${tenantId}/s/${pixelId}.gif?",
"trackingIdentifier": "${event}property=${property}&${property}=${clientId(cid-scope-cookie-fallback-name)}${extraTrackingValues}",
"defaultTrackingValues": "${trackingIdentifier}&sourceUrl=${sourceUrl}&canonicalUrl=${canonicalUrl}&referrer=${documentReferrer}&title=${title}&visitDate=${timestamp}&geoLocation=${ampGeo(ISOCountry)}&userAgent=${userAgent}"
"defaultTrackingValues": "${trackingIdentifier}&sourceUrl=${sourceUrl}&canonicalUrl=${canonicalUrl}&referrer=${documentReferrer}&title=${title}&visitDate=${timestamp}&geoLocation=${ampGeo(ISOCountry)}&userAgent=${userAgent}&canonicalHostname=${canonicalHostname}&deviceType=${deviceType}&originType=${originType}",
"trackingValuesWithoutGeo": "${trackingIdentifier}&sourceUrl=${sourceUrl}&canonicalUrl=${canonicalUrl}&referrer=${documentReferrer}&title=${title}&visitDate=${timestamp}&userAgent=${userAgent}&canonicalHostname=${canonicalHostname}&deviceType=${deviceType}&originType=${originType}"
},
"vars": {
"extraTrackingValues": ""
Expand Down

0 comments on commit a215d7b

Please sign in to comment.