Minor changes for lint/type-checking

ampproject · Jun 14, 2023 · 91920ab · 91920ab
1 parent 5320ece
commit 91920ab
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/build-system/release-tagger/utils.js b/build-system/release-tagger/utils.js
@@ -4,9 +4,11 @@
  */
 
 const dedent = require('dedent');
-const {GraphQlQueryResponseData, graphql} = require('@octokit/graphql'); // eslint-disable-line @typescript-eslint/no-unused-vars
+const {graphql} = require('@octokit/graphql');
 const {Octokit} = require('@octokit/rest');
 
+/** @typedef {import('@octokit/graphql').GraphQlQueryResponseData} GraphQlQueryResponseData */
+
 /**
  * GitHub API util functions
  */

diff --git a/build-system/tasks/build-story-localization.js b/build-system/tasks/build-story-localization.js
@@ -23,7 +23,11 @@ function getLanguageCodeFallbacks(languageCode) {
   if (!languageCode) {
     return [FALLBACK_LANGUAGE_CODE];
   }
-  const matches = languageCode.match(LANGUAGE_CODE_CHUNK_REGEX) || [];
+  const matches = languageCode.match(LANGUAGE_CODE_CHUNK_REGEX);
+  if (!matches) {
+    return [FALLBACK_LANGUAGE_CODE];
+  }
+
   return matches.reduce(
     (fallbackLanguageCodeList, _, index) => {
       const fallbackLanguageCode = matches

diff --git a/build-system/tasks/e2e/amp-driver.js b/build-system/tasks/e2e/amp-driver.js
@@ -119,7 +119,7 @@ const EnvironmentBehaviorMap = {
 
 /**
  * @param {string} url
- * @param {{isEmail: boolean}=} opts
+ * @param {{isEmail: boolean}} opts
  * @return {string}
  */
 function getViewerUrl(url, {isEmail} = {isEmail: false}) {