🏗 Run unit tests on Firefox (#22420)

ampproject · May 22, 2019 · 6a11b62 · 6a11b62
1 parent 4296d7d
commit 6a11b62
Show file tree

Hide file tree

Showing 18 changed files with 1,912 additions and 1,817 deletions.
diff --git a/ads/google/a4a/test/test-utils.js b/ads/google/a4a/test/test-utils.js
@@ -872,27 +872,31 @@ describe('Google A4A utils', () => {
       );
     });
 
-    it('should not fetch if INSUFFICIENT consent', () => {
-      sandbox.stub(Services, 'consentPolicyServiceForDocOrNull').returns(
-        Promise.resolve({
-          whenPolicyResolved: () => CONSENT_POLICY_STATE.INSUFFICIENT,
-        })
-      );
-      return expect(
-        getIdentityToken(env.win, env.ampdoc, 'default')
-      ).to.eventually.jsonEqual({});
-    });
+    it.configure()
+      .skipFirefox()
+      .run('should not fetch if INSUFFICIENT consent', () => {
+        sandbox.stub(Services, 'consentPolicyServiceForDocOrNull').returns(
+          Promise.resolve({
+            whenPolicyResolved: () => CONSENT_POLICY_STATE.INSUFFICIENT,
+          })
+        );
+        return expect(
+          getIdentityToken(env.win, env.ampdoc, 'default')
+        ).to.eventually.jsonEqual({});
+      });
 
-    it('should not fetch if UNKNOWN consent', () => {
-      sandbox.stub(Services, 'consentPolicyServiceForDocOrNull').returns(
-        Promise.resolve({
-          whenPolicyResolved: () => CONSENT_POLICY_STATE.UNKNOWN,
-        })
-      );
-      return expect(
-        getIdentityToken(env.win, env.ampdoc, 'default')
-      ).to.eventually.jsonEqual({});
-    });
+    it.configure()
+      .skipFirefox()
+      .run('should not fetch if UNKNOWN consent', () => {
+        sandbox.stub(Services, 'consentPolicyServiceForDocOrNull').returns(
+          Promise.resolve({
+            whenPolicyResolved: () => CONSENT_POLICY_STATE.UNKNOWN,
+          })
+        );
+        return expect(
+          getIdentityToken(env.win, env.ampdoc, 'default')
+        ).to.eventually.jsonEqual({});
+      });
   });
 
   describe('variables for amp-analytics', () => {

diff --git a/build-system/tasks/runtime-test/index.js b/build-system/tasks/runtime-test/index.js
@@ -131,8 +131,8 @@ function getConfig() {
       : [
           // With --saucelabs_lite, a subset of the unit tests are run.
           // Only browsers that support chai-as-promised may be included below.
-          // TODO(rsimha): Add more browsers to this list. #6039.
           'SL_Safari_12',
+          'SL_Firefox',
         ];
 
     return Object.assign({}, karmaDefault, {

diff --git a/test/unit/test-amp-context.js b/test/unit/test-amp-context.js
@@ -154,15 +154,17 @@ describe('3p ampcontext.js', () => {
     });
   });
 
-  it('should throw error if metadata missing', () => {
-    win.name = generateIncorrectAttributes();
-    const platform = new Platform(window);
-    expect(() => new AmpContext(win)).to.throw(
-      platform.isSafari()
-        ? /undefined is not an object/
-        : /Cannot read property/
-    );
-  });
+  it.configure()
+    .skipFirefox()
+    .run('should throw error if metadata missing', () => {
+      win.name = generateIncorrectAttributes();
+      const platform = new Platform(window);
+      expect(() => new AmpContext(win)).to.throw(
+        platform.isSafari()
+          ? /undefined is not an object/
+          : /Cannot read property/
+      );
+    });
 
   it('should be able to send an intersection observer request', () => {
     win.name = generateSerializedAttributes();

diff --git a/test/unit/test-ampdoc.js b/test/unit/test-ampdoc.js
@@ -247,6 +247,7 @@ describe('AmpDocService', () => {
     // TODO(dvoytenko, #11827): Make this test work on Safari.
     it.configure()
       .skipSafari()
+      .skipFirefox()
       .run('should navigate via host', () => {
         if (!shadowRoot) {
           return;