Skip to content

Commit

Permalink
Remove client-side-experiments-config.json from this repo (#37304)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielrozenberg authored Jan 5, 2022
1 parent 6bfa3ac commit 5d34580
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 146 deletions.
30 changes: 0 additions & 30 deletions .github/workflows/sync-client-side-experiments-config-to-cdn.yml

This file was deleted.

11 changes: 0 additions & 11 deletions .github/workflows/wrangler.toml

This file was deleted.

6 changes: 0 additions & 6 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@
"fileMatch": ["build-system/global-configs/caches.json"],
"url": "./build-system/json-schemas/caches.json"
},
{
"fileMatch": [
"build-system/global-configs/client-side-experiments-config.json"
],
"url": "./build-system/json-schemas/client-side-experiments-config.json"
},
{
"fileMatch": ["build-system/tasks/bundle-size/filesize.json"],
"url": "./build-system/json-schemas/filesize.json"
Expand Down
4 changes: 0 additions & 4 deletions build-system/global-configs/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
},
],
},
{
pattern: 'client-side-experiments-config.json',
owners: [{name: 'danielrozenberg'}, {name: 'jridgewell'}],
},
{
pattern: '*-config.json',
owners: [{name: 'alanorozco', requestReviews: false}],
Expand Down
30 changes: 2 additions & 28 deletions build-system/global-configs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,32 +83,6 @@ amp release --flavor="custom-prod"
- Flag `--version_override` is not supported.
- `AMP_CONFIG` can be customized with [`custom-config.json`](#custom-configjson) to further tailor the build.

# client-side-experiments-config.json
# Looking for client-side-experiments-config.json?

This config is used to run client side diverted experiments, adding runtime support for deploying AMP experiment configuration updates faster via the CDN and cache pages. It is complimentary to `{canary,prod,custom}-config.json` and takes precedence over them. (See I2I issue: [#34013](https://github.com/ampproject/amphtml/issues/34013))

The JSON object must contain exactly one field `experiments` which is an array of experiment definition objects with the following fields:

- `name`: experiment name
- `percentage`: percentage of AMP page views that will activate this experiment (between 0 and 1)
- `rtvPrefix`: (optional) array of RTV prefixes that will cause this experiment to be active, with period (`.`) acting as a wildcard. e.g., `["00", "0.2106"]` will cause this experiment to activate on the Experimental channel, and on every channel for the month of June, 2021 (see [Versioning section in amp-framework-hosting.md](../../docs/spec/amp-framework-hosting.md#versioning) for an explanation of AMP versions and RTV numbers).

Example:

```json
{
"experiments": [
{
"name": "chunked-amp",
"percentage": 0.5,
},
{
"name": "version-locking",
"percentage": 1,
"rtvPrefix": ["01", "02", "03", "04", "05"]
}
]
}
```

Once merged onto the `main` branch, this file is automatically picked up by the AMP CDN (usually within 1-2 hours from PR merge) and its content is injected into `v0.[m]js`. AMP caches can also inject the contents of this file verbatim into pages inside a `<script language=text/json id=__AMP_EXP>{...}</script>` element.
This file now resides in the [ampproject/cdn-configuration](https://github.com/ampproject/cdn-configuration/blob/main/configs/client-side-experiments.json) repository.
28 changes: 0 additions & 28 deletions build-system/global-configs/client-side-experiments-config.json

This file was deleted.

39 changes: 0 additions & 39 deletions build-system/json-schemas/client-side-experiments-config.json

This file was deleted.

0 comments on commit 5d34580

Please sign in to comment.