Tighten types related to element attribute modification.

Part of #9876
ampproject · Jun 22, 2017 · 5343a79 · 5343a79
1 parent faf9745
commit 5343a79
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/extensions/amp-call-tracking/0.1/amp-call-tracking.js b/extensions/amp-call-tracking/0.1/amp-call-tracking.js
@@ -32,7 +32,7 @@ let cachedResponsePromises_ = {};
  * Fetches vendor response.
  * @param {!Window} win
  * @param {!string} url
- * @return {!Promise<Object>}
+ * @return {!Promise<JsonObject>}
  */
 function fetch_(win, url) {
   if (!(url in cachedResponsePromises_)) {

diff --git a/src/base-element.js b/src/base-element.js
@@ -932,7 +932,7 @@ export class BaseElement {
    * @note Boolean attributes have a value of `true` and `false` when
    *       present and missing, respectively.
    * @param {
-   *   !Object<string, (null|boolean|string|number|Array|Object)>
+   *   !JsonObject<string, (null|boolean|string|number|Array|Object)>
    * } unusedMutations
    */
   mutatedAttributesCallback(unusedMutations) {

diff --git a/src/custom-element.js b/src/custom-element.js
@@ -1463,7 +1463,7 @@ function createBaseCustomElementClass(win) {
      * @note Boolean attributes have a value of `true` and `false` when
      *       present and missing, respectively.
      * @param {
-     *   !Object<string, (null|boolean|string|number|Array|Object)>
+     *   !JsonObject<string, (null|boolean|string|number|Array|Object)>
      * } mutations
      */
     mutatedAttributesCallback(mutations) {

diff --git a/src/dom.js b/src/dom.js
@@ -149,7 +149,7 @@ export function copyChildren(from, to) {
 /**
  * Add attributes to an element.
  * @param {!Element} element
- * @param {!Object<string, string>} attributes
+ * @param {!JsonObject<string, string>} attributes
  * @return {!Element} created element
  */
 export function addAttributesToElement(element, attributes) {