Skip flaky A4A test (#22165)

ampproject · May 9, 2019 · 4090a82 · 4090a82
1 parent fe79faf
commit 4090a82
Showing 1 changed file with 27 additions and 25 deletions.
diff --git a/test/integration/test-amp-ad-fake.js b/test/integration/test-amp-ad-fake.js
@@ -32,33 +32,35 @@ describe('A4A', function() {
       `,
     extensions: ['amp-ad'],
   }, () => {
-    it('should layout amp-img, amp-pixel, amp-analytics', () => {
-      // See amp4test.js for creative content
-      return Promise.all([
-        RequestBank.withdraw('image'),
-        RequestBank.withdraw('pixel'),
-        RequestBank.withdraw('analytics'),
-      ]).then(reqs => {
-        const imageReq = reqs[0];
-        const pixelReq = reqs[1];
-        const analyticsReq = reqs[2];
-        expect(imageReq.url).to.equal('/');
-        expect(pixelReq.url).to.equal('/foo?cid=');
-        expect(analyticsReq.url).to.match(/^\/bar\?/);
-        const queries =
+    // TODO(#21545): Unskip flaky test
+    it.configure().skipFirefox().run(
+        'should layout amp-img, amp-pixel, amp-analytics', () => {
+          // See amp4test.js for creative content
+          return Promise.all([
+            RequestBank.withdraw('image'),
+            RequestBank.withdraw('pixel'),
+            RequestBank.withdraw('analytics'),
+          ]).then(reqs => {
+            const imageReq = reqs[0];
+            const pixelReq = reqs[1];
+            const analyticsReq = reqs[2];
+            expect(imageReq.url).to.equal('/');
+            expect(pixelReq.url).to.equal('/foo?cid=');
+            expect(analyticsReq.url).to.match(/^\/bar\?/);
+            const queries =
             parseQueryString(analyticsReq.url.substr('/bar'.length));
-        expect(queries).to.include({
-          title: 'AMP TEST', // ${title},
-          cid: '', // ${clientId(a)}
-          navTiming: '0', // ${navTiming(requestStart,requestStart)}
-          navType: '0', // ${navType}
-          navRedirectCount: '0', // ${navRedirectCount}
+            expect(queries).to.include({
+              title: 'AMP TEST', // ${title},
+              cid: '', // ${clientId(a)}
+              navTiming: '0', // ${navTiming(requestStart,requestStart)}
+              navType: '0', // ${navType}
+              navRedirectCount: '0', // ${navRedirectCount}
+            });
+            expect(queries['ampdocUrl']).to.contain('http://localhost:9876/amp4test/compose-doc?');
+            expect(queries['canonicalUrl']).to.equal('http://nonblocking.io/');
+            expect(queries['img']).to.contain('/deposit/image'); // ${htmlAttr(amp-img,src)}
+          });
         });
-        expect(queries['ampdocUrl']).to.contain('http://localhost:9876/amp4test/compose-doc?');
-        expect(queries['canonicalUrl']).to.equal('http://nonblocking.io/');
-        expect(queries['img']).to.contain('/deposit/image'); // ${htmlAttr(amp-img,src)}
-      });
-    });
   });
 
   const src = addParamsToUrl('/amp4test/compose-doc', {