Skip to content

Update dependencies #5554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 60 commits into from
Closed

Update dependencies #5554

wants to merge 60 commits into from

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Oct 31, 2020

Summary

The following dependencies cannot be updated as yet:

  • The webpack dependency cannot be updated to v5 as yet until the Gutenberg packages we use support it (currently being worked on in Upgrade webpack to version 5 WordPress/gutenberg#26382);

  • The terser-webpack-plugin dependency cannot be updated to v5 as it needs webpack v5;

  • The phpdocumentor/reflection dependency cannot be updated to v4 due to incompatible PHP version constraints (and even if it were updated our current doc generation command will break).

Apart from that, the localheinz/composer-normalize dependency (used in the Travis lint job) has been abandoned and is replaced with its successor, ergebnis/composer-normalize. The dependency is locked to v2.9.0 as the latest release (v2.9.1) has dropped support for Composer v1.

Other miscellaneous changes:

In total, 51 dependencies are updated.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added dependencies Pull requests that update a dependency file WS:Core Work stream for Plugin core labels Oct 31, 2020
@pierlon pierlon added this to the v2.1 milestone Oct 31, 2020
@pierlon pierlon self-assigned this Oct 31, 2020
@pierlon pierlon marked this pull request as ready for review November 1, 2020 04:58
@westonruter
Copy link
Member

A build is failing with an error:

TypeError: rule.use.find is not a function

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

Plugin builds for 36fe212 are ready 🛎️!

@pierlon
Copy link
Contributor Author

pierlon commented Nov 1, 2020

A build is failing with an error:

TypeError: rule.use.find is not a function

Should now be resolved in 36fe212.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awaiting +1 from @johnwatkins0.

Copy link
Contributor

@johnwatkins0 johnwatkins0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@westonruter
Copy link
Member

@pierlon there appear to be conflicts which need resolving before I can merge this.

@westonruter westonruter closed this Nov 2, 2020
@pierlon pierlon deleted the update-dependencies branch November 2, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants