-
Notifications
You must be signed in to change notification settings - Fork 381
Update dependencies #5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #5554
Conversation
v2.9.1 of the plugin dropped support for Composer v1, see ergebnis/composer-normalize#597
A build is failing with an error:
|
Plugin builds for 36fe212 are ready 🛎️!
|
Should now be resolved in 36fe212. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awaiting +1 from @johnwatkins0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Update dependencies
@pierlon there appear to be conflicts which need resolving before I can merge this. |
Summary
The following dependencies cannot be updated as yet:
The
webpack
dependency cannot be updated to v5 as yet until the Gutenberg packages we use support it (currently being worked on in Upgrade webpack to version 5 WordPress/gutenberg#26382);The
terser-webpack-plugin
dependency cannot be updated to v5 as it needswebpack
v5;The
phpdocumentor/reflection
dependency cannot be updated to v4 due to incompatible PHP version constraints (and even if it were updated our current doc generation command will break).Apart from that, the localheinz/composer-normalize dependency (used in the Travis lint job) has been abandoned and is replaced with its successor, ergebnis/composer-normalize. The dependency is locked to v2.9.0 as the latest release (v2.9.1) has dropped support for Composer v1.
Other miscellaneous changes:
webpack-cli
dependency has been removed as it does not seem to be in use by the plugin.In total, 51 dependencies are updated.
Checklist