Fix Template Inserter

[miina]

Fixes #3016.
Closes #2887

Todo:

• Fix Template style.
• E2E

[swissspidy]

Sounds like an ideal use case for Array.prototype.reduce :-)

[swissspidy]

We might need to add another block deprecation for the quote block:

Content generated by `save` function:

<blockquote class="wp-block-quote has-text-align-center is-style-white"><p>Everyone soon or late comes round Rome</p><cite>Robert Browning</cite></blockquote>

Content retrieved from post body:

<blockquote style="text-align:center" class="wp-block-quote is-style-white"><p>Everyone soon or late comes round Rome</p><cite>Robert Browning</cite></blockquote>

Gutenberg is going away from these text-align inline styles.

[miina]

Gutenberg is going away from these text-align inline styles.

If that happens then perhaps the deprecation will be implemented upstream instead?

[swissspidy]

They did: WordPress/gutenberg#16779

Does that mean it's not working? 🤔 Or are we perhaps overriding the core deprecation?

[swissspidy]

In any case, we can look at that independent from this PR if needed.

[miina]

Will check if that's an easy fix.

[miina]

Does that mean it's not working? 🤔 Or are we perhaps overriding the core deprecation?

It means that it was working properly, otherwise, it would have given a block validation error inside the template :)

Updated the template and seems to work OK now (OK meaning without console errors).

[kienstra]

Approved

Hi @miina,
This looks good. The Template Inserter now displays as expected, when using the lastest from the master branch of Gutenberg.

Before

After